Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Nitpicking

Re: Nitpicking

From: Magnus Holmgren <lear_at_algonet.se>
Date: Sun, 01 Sep 2002 21:30:11 +0200

Björn Stenberg wrote:

> > * Using "button_get(true);" in volume and ff/rewind isn't great, since
> > it stops time displays. wps_refresh() needs to be called now and then.
>
> Ffwd/rew alters the time display anyway (and updates it peridocally),
> so there's no point it calling wps_refresh().

Yes, my mistake.

> The volume changes i can maybe agree on, although I'd say people
> normally release MENU immediately after adjusting volume, and then
> the time updates. The time freeze only occurs if you keep holding
> down MENU.

And even if you don't opt to change the volume (i.e., it happens within
menu()). :)

However, I tend to spend a few seconds finding the right volume, so I
noticed the "problem".

-- 
Magnus Holmgren
Received on 2002-09-01

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy