dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: [PATCH] Minor wps.c changes

Re: [PATCH] Minor wps.c changes

From: Justin Heiner <>
Date: Sat, 7 Sep 2002 13:59:01 -0700 (PDT)

--- Magnus Holmgren <> wrote:
> Hi,
> The attached patch fixes a couple of small details in wps.c and adds
> some information in the player ID3 info screen. The following things are
> changed:
> * Make sure wps_refresh and status_draw are called frequently (i.e., a
> couple of times per second) when changing volume and showing the ID3
> info screen, so that things that should update (play time, charging
> indicator) really do update.

Seems like a goodidea

> * When an USB cable is detected, turn off various icons on the display.

Again, agreed

> * In the player ID3 info screen, the "header screen" ("-ID3 info-") is
> removed, since it's not important and I find it annoying. :) Also, added
> track number and playlist position/size. Also, corrected the frequency
> text (it shows Hz, not kHz).

I think having that displayed at least for a tiny bit isn't that bad. I think
that it's good sometimes to have an indicator of where you are, if it doesn't
severely detract from the use of the device. It's good for people who don't
know the device very well.

> * Turn off the (player) audio icon when going to the menu.

Another one that I think should stay. The player icon being there means that
you're in a menu while playing something. I think it gives more information
about the status of the device, which is never a bad thing.


Do You Yahoo!?
Yahoo! Finance - Get real-time stock quotes
Received on 2002-09-07

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy