Rockbox mail archiveSubject: Re: [PATCH] Minor wps.c changes
Re: [PATCH] Minor wps.c changes
From: Magnus Holmgren <lear_at_algonet.se>
Date: Sun, 08 Sep 2002 11:10:55 +0200
Justin Heiner wrote:
> > * Make sure wps_refresh and status_draw are called frequently (i.e., a
> > couple of times per second) when changing volume and showing the ID3
> > info screen, so that things that should update (play time, charging
> > indicator) really do update.
> Seems like a goodidea
But the patch needs some work, I realized now. The "changed" flag in the
ID3 info screen needs to be re-introduced. And there are other places
where refreshes are needed...
> > * In the player ID3 info screen, the "header screen" ("-ID3 info-") is
> > removed, since it's not important and I find it annoying. :) Also, added
> > track number and playlist position/size. Also, corrected the frequency
> > text (it shows Hz, not kHz).
> I think having that displayed at least for a tiny bit isn't that bad. I think
> that it's good sometimes to have an indicator of where you are, if it doesn't
> severely detract from the use of the device. It's good for people who don't
> know the device very well.
> > * Turn off the (player) audio icon when going to the menu.
> Another one that I think should stay. The player icon being there means that
> you're in a menu while playing something. I think it gives more information
> about the status of the device, which is never a bad thing.
On the other hand, by not showing the audio icon in the menu (menus are
menus, regardless of where you came from), you can use the audio and
param icons as an ID3 info indicator (makes sense; audio "parameters"
are being shown). And you always have the play icon indicating that
something is playing.
-- Magnus HolmgrenReceived on 2002-09-08