Rockbox mail archiveSubject: Re: [PATCH] compiled-in and loadable fonts
Re: [PATCH] compiled-in and loadable fonts
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 12 Sep 2002 15:41:43 +0200 (MET DST)
On Wed, 11 Sep 2002, Greg Haerr wrote:
> To make the system for testing, ./configure and select NO for loadable
> fonts, and YES for proportional fonts. Then copy some .fnt file to
> /system.fnt (I am using the large courB14.fnt to show the coolness of large
I removed the dependency of this before I committed. This is now built-in
default. The propfonts/loadable fonts defines are now history.
> To create a new .fnt file for your own pleasure, say from source
> courB08.bdf, do the following:
We really need a more comfortable way of doing this, a shell script and a
perl script makes things very hard for windows users.
> 1. This patch doesn't cleanup the LOADABLE_FONTS and non LCD_PROPFONTS
> code. I'll do that after the patch is accepted.
I did that.
> Also, the Cyrillic font isn't tested yet, I'll try to do that tonight and
> talk with Alex about it (it needs codepage support added to my code)
Yes, that needs to be sorted out. That fat.c code used before was horribly
> 4. Currently, .bdf files get fully converted, supporting ISO8859-1. I'm
> going to add an option for just ascii 20-0x7e to the conversion files.
> This will make font and compiled-in files smaller.
Right, the helv08.bdf font I've had testing with creates a HUGE .fnt file
that doesn't load properly. And thus I haven't been able to test your code
for proportional fonts, just because I know of no other prop .bdf.
> 5. I want to rename some lcd_ functions to a higher level, that is,
> font_xxx. This is because these functions are not strictly driver level
> function, and all depend on lcd_bitmap. Likewise, the lcd_drawline et al
> should move to a different file at least, perhaps firmware/graphics.c.
> I'll look at all this after the patch is accepted and we have a single font
I agree with that.
You'll notice that I re-indented your code to Rockbox standard and a few
other minor things.
Now, the work with getting this to work properly all over can begin!
-- Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/Received on 2002-09-12