Rockbox mail archiveSubject: Re: cvs: firmware mpeg.c,1.122,1.123
Re: cvs: firmware mpeg.c,1.122,1.123
From: Björn Stenberg <bjorn_at_haxx.se>
Date: Fri, 13 Sep 2002 17:29:59 +0200
Eric Linenberg wrote:
> WOWSA! This is a GREAT feature. However as with many features, there
> comes some bugs.
Yes. The pitch feature is pushing the envelope in many aspects, which has impact on other parts of the behaviour.
> The time display in the song is all screwey once this feature is used.
Yup. The time shows elapsed real time and makes no compensation for faster or slower playback. We could try making a crude adjustment using the pitch percent.
> One time I got "stuck" in the pitch screen -- held down ON and then I
> had to hit ON again to get out of the screen. This only happened once
Yes. This happens if you for example hold down ON+UP and release them simultaneously. I'll see if I can fix that.
> If you hit ON and UP or DOWN at the same time it will just start
> changing the pitch WITHOUT entering the pitch screen.
It was actually intended behaviour. The reason I implemeted delayed drawing of the on screen is that otherwise the screen flickers annoyingly when you just want to go from the wps to the browser.
I've now changed it so the on screen is drawn as soon as you use a combined ON key. This should make it less confusing.
> Now, here is an idea I have. When you fast forward or rewind what
> about instead of playing samples of the song (I think this is what
> most CD players do) play the song, and just adjust the pitch as the
> ff/rw speed increases?
We can't go faster than around 200%, so it would be a very slow ffwd.
-- BjörnReceived on 2002-09-13