Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Yes/No Prompt Quirk

Re: Yes/No Prompt Quirk

From: Magnus Holmgren <lear_at_algonet.se>
Date: Fri, 13 Sep 2002 18:50:56 +0200

Mike Soultanian wrote:
 
> On my recorder, when you hit UP it selects NO and DOWN selects YES.
> This is slightly counter-intuitive...

Yep. It's similar on the player. The fix is easy though. In
settings.c:set_bool_options(), change:

    char* names[] = { yes_str, no_str };
    int value = !*variable;
    set_option(string, &value, names, 2, NULL);
    *variable = !value;

to

    char* names[] = { no_str, yes_str };
    int value = *variable;
    set_option(string, &value, names, 2, NULL);
    *variable = value;

which is more logical, IMO.

-- 
Magnus Holmgren
Received on 2002-09-13

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy