Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware id3.c,1.41,1.42

Re: cvs: firmware id3.c,1.41,1.42

From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 16 Sep 2002 11:28:53 +0200 (CEST)

Daniel Stenberg wrote:

> Modified Files:
> id3.c
> Log Message:
> if the id3v2 tags avaiable are bigger than our buffer size, at least try
> to get the ones that is within the boundaries.

Won't work well, because the ID3 parsing loop won't detect end-of-buffer properly. Either the while statement is made more fool-proof (as it is now, "size - readsize" can wrap), or the else part in the "frame-header if-statement" needs the following code:

    if(headerlen > (size - readsize))
        headerlen = (size - readsize);

(I've encountered this problem; see http://rockbox.haxx.se/mail/archive/rockbox-archive-2002-08/0686.shtml)

  Magnus
Received on 2002-09-16

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy