Rockbox mail archiveSubject: Re: cvs: firmware id3.c,1.41,1.42
Re: cvs: firmware id3.c,1.41,1.42
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 16 Sep 2002 11:45:12 +0200 (MET DST)
On Mon, 16 Sep 2002, Magnus Holmgren wrote:
> > if the id3v2 tags avaiable are bigger than our buffer size, at least try
> > to get the ones that is within the boundaries.
> Won't work well, because the ID3 parsing loop won't detect end-of-buffer
> properly. Either the while statement is made more fool-proof (as it is now,
> "size - readsize" can wrap), or the else part in the "frame-header
> if-statement" needs the following code:
Thanks for your heads up.
> (I've encountered this problem; see
Wouldn't be enough to just make sure that when we encounter an unown tag, we
check that if readsize (after "readsize += headerlen") gets bigger than size,
we bail out of the loop?
-- Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/Received on 2002-09-16