Rockbox mail archive
Subject: Re: cvs: firmware id3.c,1.41,1.42Re: cvs: firmware id3.c,1.41,1.42
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 16 Sep 2002 11:56:25 +0200 (CEST)
Daniel Stenberg wrote:
> Wouldn't be enough to just make sure that when we encounter an unown tag, we
> check that if readsize (after "readsize += headerlen") gets bigger than size,
> we bail out of the loop?
That'd work too, but why treat this case any differently? :) But with my suggestion, the bail-out is only delayed slightly (and the code could perhaps be generalized a bit?).
Magnus
Received on 2002-09-16
Date: Mon, 16 Sep 2002 11:56:25 +0200 (CEST)
Daniel Stenberg wrote:
> Wouldn't be enough to just make sure that when we encounter an unown tag, we
> check that if readsize (after "readsize += headerlen") gets bigger than size,
> we bail out of the loop?
That'd work too, but why treat this case any differently? :) But with my suggestion, the bail-out is only delayed slightly (and the code could perhaps be generalized a bit?).
Magnus
Received on 2002-09-16
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy