Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware id3.c,1.42,1.43

Re: cvs: firmware id3.c,1.42,1.43

From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 16 Sep 2002 12:38:05 +0200 (CEST)

Daniel Stenberg wrote:

> Modified Files:
> id3.c
> Log Message:
> When getting tag contents, we might read a tag which has a part of it within
> our buffer and part outside. This adjusts so that we only attempt to read
> the part of the tag that is inside the buffer. Magnus Holmgren helped out
> here!

Hm... Now all "if(headerlen > (size - readsize)) ..." statements within the header checks can be removed - but you've also changed what headerlen will be for a known tag that doesn't fit in the buffer (I guess we can live with that)... :)

  Magnus
Received on 2002-09-16

Page was last modified "Mon Nov 16 10:57:21 2020" The Rockbox Crew -- Privacy Policy