dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: cvs: firmware id3.c,1.42,1.43
From: Magnus Holmgren (
Date: 2002-09-16

Daniel Stenberg wrote:

> Modified Files:
> id3.c
> Log Message:
> When getting tag contents, we might read a tag which has a part of it within
> our buffer and part outside. This adjusts so that we only attempt to read
> the part of the tag that is inside the buffer. Magnus Holmgren helped out
> here!

Hm... Now all "if(headerlen > (size - readsize)) ..." statements within the header checks can be removed - but you've also changed what headerlen will be for a known tag that doesn't fit in the buffer (I guess we can live with that)... :)


Page was last modified "Jan 10 2012" The Rockbox Crew