Rockbox mail archiveSubject: Re: Extending .eq
Re: Extending .eq
From: Chad <chad_at_thelockwoods.net>
Date: Sun, 22 Sep 2002 20:21:38 -0700
On Sunday 22 September 2002 11:51 am, you wrote:
> Björn Stenberg wrote:
> > > But what I actually don't like is the file format itself
> > > with this weird # to substitute something which imoh an eol
> > > should do.
> > I agree completely. I will change this soon if nobody else beats me to
> > it. Settings files should be simple:
> > volume: 75
> > bass: 0
> > treble: 0
> I've made a start on it, but I'm not sure when I can get it finished (a
> couple of days probably, but no later than next weekend). My first idea
> was "volume = 75", but I can change that (in fact, the above would make
> the code a little simpler :). I'll keep comment support ("#"; either
> alone on a line, or after a setting) if no-one dislikes that.
Yes please keep the comment support.
> Note, however, that my implementation is intentionally made for sound
> related settings only. Adding support for e.g. shuffle would be a bit
> ugly. :)
What did you change from the way the origonal code worked to make it
"intentionally made for sound'?
It was very easy to extended the exsisting code to include shuffle..
Though the "if else" is nested very deep.
Received on 2002-09-23