Rockbox mail archiveSubject: Re: Extending .eq
Re: Extending .eq
From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 23 Sep 2002 11:43:42 +0200 (MEST)
> What did you change from the way the origonal code worked to make it
> "intentionally made for sound'?
> It was very easy to extended the exsisting code to include shuffle..
> Though the "if else" is nested very deep.
Because the code for the sound options differed in little but the SOUND_* argument used in various calls in mpeg.c. With the addition of an opposite of the mpeg_val2phys function, you just need to figure out what SOUND_* value to use (and where to store the value); the rest of the code can then be generic for all (sound) settings.
But adding support for non-sound options wouldn't be that hard really. It doesn't seem to be the proper place in what started as an "equalizer" setting though...
Received on 2002-09-23