dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: cvs: apps settings.c,1.67,1.68

Re: cvs: apps settings.c,1.67,1.68

From: Magnus Holmgren <>
Date: Wed, 2 Oct 2002 19:02:54 +0200 (MEST)

Björn Stenberg wrote:

> Modified Files:
> settings.c
> Log Message:
> Changed .eq file format to simple 'setting: value' model.

Since I wrote the original patch, I just have to make a few comments. :)

The code was cleaned up a lot, which is nice, but the visual feedback and error handling is gone (and they caused much of the complexity). I'm not sure what is best though...

read_line was deliberately written to always null-terminate the buffer. That isn't the case any more, AFAICS, which could cause problems...

Received on 2002-10-02

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy