Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: apps settings.c,1.67,1.68

Re: cvs: apps settings.c,1.67,1.68

From: Magnus Holmgren <lear_at_algonet.se>
Date: Fri, 4 Oct 2002 10:58:19 +0200 (MEST)

Björn Stenberg wrote:

> Yes. I removed that, since I think it should rather be
> handled in tree.c after the loading is completed.

Though it's limited what can be handled there... :)

> It null terminates, unless the string was completely
> filled. This is standard behaviour, just like strncpy etc.
> However, I'm inclined to agree with you that this can cause
> problems, since users of read_line (such as myself ;) will
> likely forget to check this.

I dislike strncpy for that very reason.

Another read_line thing: a line consisting of nothing but a line feed returns 0, breaking the read... That's why I made read_line return true if something had been read.

  Magnus
Received on 2002-10-04

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew