Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: [patch] peakmeter

Re: [patch] peakmeter

From: Andreas Zwirtes <zwirtes_at_gmx.de>
Date: Mon, 07 Oct 2002 20:55:06 +0200

Hi!

Thank you very much! I already saw the thing with the space saver
alignment, but did
not think about c++ comments. In fact, I thought // is also known by ANSI C.

Variable names: It makes sense to give them a prefix to see where they
come from.
I didn't think about it, because i mostly write OO code and components.
We never
use global variables. That's different when programming a controller, I
understand.

It's a bit hard to switch coding conventions between company <-->
rockbox, but
that's life. Over all, writing for rockbox is much more fun!

Question: I think it is very usefull to give the variables type
information like
iStatus (that now would be istatus). i stands for integer, l for long
and so on.
Is there also a silent convention on that?

To your question, Phil: principally it's straigt forward (or should I
say reverse? ;) to make
an invers function. I'll think about it, when dB code V2 without div is
out. Don't
want to do it twice...

Andreas aka radhard
Received on 2002-10-07

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy