Rockbox mail archiveSubject: Re: Test the "scroll text file" patch ?
Re: Test the "scroll text file" patch ?
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 8 Oct 2002 09:29:56 +0200 (MET DST)
On Tue, 8 Oct 2002, Olivier Martin - diic3 wrote:
> Did someone test my patch ?
No, but I read the source.
> If yes, can you give me your observations.
1. It only works on the player.
2. Why all the seeking to (..., 0, SEEK_CUR) ? Can't you keep track of the
current seek position with a variable instead?
3. I'd recommend using a bigger buffer for the read, so that the harddrive
really can spindown properly between the reads.
4. Perhaps most of all, can't this functionality get built-in on the already
existing text viewer? It seems a bit excessive to feature two different
text viewers, only using slightly different approaches.
I think it would make more sense to add options/modify the existing one.
-- Daniel "Bagder" Stenberg -- http://rockbox.haxx.se/Received on 2002-10-08