Rockbox mail archiveSubject: Re: disk write testing
Re: disk write testing
From: Björn Stenberg <bjorn_at_haxx.se>
Date: Tue, 5 Nov 2002 15:40:55 +0100
Greg Haerr wrote:
> WRT read-access updating, I wasn't trying to suggest that we have to have
> it, but rather than the current design doesn't handle it well. For instance,
> we have a "special" fat_closewrite entry point that should be just a
> fat_close entry point, handling read or write closing.
Having a fat_close() for read-only files is pointless, since there is nothing that needs to be done. Read access update could be done in fat_open(), or we'd simply add a call in file.c:close() to a new fat_close() function.
I fail to see how the absense of empty functions that do nothing is a design problem. :-)
-- BjörnReceived on 2002-11-05