From: <for_spam_at_gmx.de>
Date: Sun, 5 Jan 2003 14:26:06 +0100 (MET)

Hi Rockboxers,

In main_menu.c we had:

int show_logo( void )
{
#ifdef HAVE_LCD_BITMAP
    char version[32];
    unsigned char *ptr=rockbox112x37;
    int height, i, font_h, font_w;

    lcd_clear_display();

    for(i=0; i < 37; i+=8) {
        /* the bitmap function doesn't work with full-height bitmaps
           so we "stripe" the logo output */
        lcd_bitmap(ptr, 0, 10+i, 112, (37-i)>8?8:37-i, false);
        ptr += 112;
    }
    height = 37;

Wondered a little bit about that and replaced 37 with 64 (height of
display):

int show_logo( void )
{
#ifdef HAVE_LCD_BITMAP
    char version[32];
    unsigned char *ptr=rockbox112x37;
    int height, i, font_h, font_w;

    lcd_clear_display();

    for(i=0; i <= 64; i+=8) {
       lcd_bitmap(ptr, 0, i, 112, (64-i)>8?8:64-i, false);
        ptr += 112;
    }
    height = 64;

Works fine with my recorder. ( replaced rockbox137x37 with custom logo - see
http://rockbox.my-vserver.de/micromusic_archos_jb20rec.jpg )

Was there a bug in lcd_bitmap() which has been solved without show_logo()
being
modified, too ?
What about show_logo( unsigned char *ptr ) ? This will add flexibility to
this routine.
One could do a show_logo(this_logo), show_logo(that_logo)..... then.
regards
Roland

-- 
+++ GMX - Mail, Messaging & more  http://www.gmx.net +++
NEU: Mit GMX ins Internet. Rund um die Uhr für 1 ct/ Min. surfen!

Received on 2003-01-05