Rockbox mail archiveSubject: RE: Latest Bookmarking Patch
RE: Latest Bookmarking Patch
From: Benjamin <mailinglists_at_samuraipanda.com>
Date: Sat, 1 Feb 2003 09:39:50 -0800
I misread your mail. I'll explain why I changed the code from
global_settings.resume in tree.c.
There are two places where I made this change, both occur when loading a
file to be played (MP3 or M3U). In both cases, I want to intercept the
call to ensure that a auto-load is not necessary. If one is, then load
to the bookmark and play at that point. If autoload is not enabled, or
the user doesn't want to auto-load, then play as normal. In either
case, I eliminated the global_settings.resume check because I grab the
global_settings.resume_file information, which wouldn't be set if resume
is not enabled. Does that make sense?
From: owner-rockbox_at_cool.haxx.se [mailto:owner-rockbox_at_cool.haxx.se] On
Behalf Of Daniel Stenberg
Sent: Saturday, February 01, 2003 7:22 AM
Subject: RE: Latest Bookmarking Patch
On Sat, 1 Feb 2003, Benjamin wrote:
Thanks for all your work on this feature. I do however have some remarks
on your recent patch (dated feb 1 2003):
* It still contains CRLF newlines all over.
* On several places in the code you have changed a section like:
with your new code that looks like this:
Evidently, you alter the flow and I'm not convinced that you should do
that. Is it on purpose?
* I suggest you use button_get(true) instead of button_get_w_tmo() if
not gonna do anything special after the timeout has elapsed.
* The bookmark_debug_print() function should probably be replaced with
DEBUGF() in case you really want it to remain.
Otherwise I think it looks mighty fine!
-- Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/Received on 2003-02-01