From: <jerome_at_geekrox.com>
Date: Mon, 3 Feb 2003 10:47:42 -0800

Quoting Björn Stenberg <bjorn_at_haxx.se>:

> Jerome Kuptz wrote:
> > Though I would like if Bjorn/Daniel/Linus or somebody to take a look at
> how
> > I handled the key combo in wps_show.
>
> This is one of the features I believe would be better to put in the menu than
> add YAOKC (Yet Another Obscure Key Combination). I know at least the car
> users in the audience hates when we put things on two-key combos. And many
> other people simply never finds these features.
>
Of course Bjorn you did suggest taking the On + Play combo in a previous thread
related to this same functionality :D.

http://rockbox.haxx.se/mail/archive/rockbox-archive-2003-01/0999.shtml

I understand your concern as I use my archos in the car and train. I could put
in a top level menu named "Save Favorite," but if it has to go into sub-menus
then a YAOKC _may_ be required imo. Some may ask about deleting the favorites,
but since it is just a playlist it can be managed in the same manner as any
playlist. Unless of course someone sees the need to have both a key combo and a
supplementing menu?

> As for the code, the bool parameter to button_get() controls whether it
> should block or not. 'true' is not a good idea if you don't plan to hang
> waiting for a key press.

I'll fix that. Thanks for looking.

--jk
Received on 2003-02-03