Rockbox mail archiveSubject: Re: FM Recorder - backlight fix
Re: FM Recorder - backlight fix
From: Mike Holden <mike_at_mikeholden.uklinux.net>
Date: Wed, 12 Feb 2003 10:05:03 -0000 (GMT)
Bjorn has already fixed the bug in settings and updated the fix in CVS, so
FM Recorder users should disable Disk Poweroff in their settings screen to
see the backlight in all its glory, from tonight's daily build onwards!
Mike Holden said:
> I have found the problem with the FM backlight not working.
> Basically, when the harddrive powers down, then the backlight is
> disabled, until the harddrive is powered on again.
> I have submitted a bug at
> which is part of the problem, in that regardless of what setting you
> have for Disk Poweroff, the disk always powers off 2 seconds after it
> spins down. THis is due to a bug in settings.c, which checks the wrong
> value in a #ifdef (it checks for ATA_POWER_OFF, but the value is set in
> If this bug is fixed, then FM will work the backlight correctly if you
> set Disk Poweroff to No - it is a quick, one-line fix in settings.c to
> use the correct #defined value, which should not require much in the way
> of testing, so hopefully will be fixed quickly!
> If Disk Poweroff is enabled however, then the fix in that case needs
> more discussion. One solution would be to power the disk up and down in
> the backlight on and off calls, but I don't know how that kind of
> solution would go down with the "keepers of the code"! Another option
> would be to remove the Disk Poweroff option from the FM model. I assume
> this is primarily a battery saver feature, but given the current runtime
> we get, maybe this isn't such a big issue?
> What opinions do other users have about this?
> Mike Holden
> Mike Holden's Rockbox pages:
Received on 2003-02-12