Rockbox mail archive
Subject: Re: cvs: apps settings.c,1.114,1.115 settings.h,1.69,1.70 settings_menu.c,1.97,1.98 wps.c,1.178,1.179Re: cvs: apps settings.c,1.114,1.115 settings.h,1.69,1.70 settings_menu.c,1.97,1.98 wps.c,1.178,1.179
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Brian King <brking_at_charter.net>
Date: Sun, 16 Feb 2003 10:33:41 -0600
I experienced the same thing on my player. Your change worked for me as
well.
-Brian
Magnus Holmgren wrote:
> Bjorn Stenberg wrote:
>
>> + /* fade out */
>> + int current_volume = global_settings.volume;
>> +
>> + while (current_volume > 20) { + current_volume
>> -= 2;
>> + sleep(1);
>> + mpeg_sound_set(SOUND_VOLUME, current_volume);
>> + }
>> + mpeg_pause();
>> + sleep(1); /* let mpeg thread run */
>> +
>> + /* reset volume to what it was before the fade */
>> + mpeg_sound_set(SOUND_VOLUME, global_settings.volume);
>
>
> The last sleep() in the fade out is too short, in my experience (using a
> player). The volume is reset before the MPEG thread has stopped the
> playback, so there's a brief burst of music at normal volume. I tried
> using HZ/10 as sleep, and that seems to work fine. HZ/15 is slightly too
> short.
>
Received on 2003-02-16
Date: Sun, 16 Feb 2003 10:33:41 -0600
I experienced the same thing on my player. Your change worked for me as
well.
-Brian
Magnus Holmgren wrote:
> Bjorn Stenberg wrote:
>
>> + /* fade out */
>> + int current_volume = global_settings.volume;
>> +
>> + while (current_volume > 20) { + current_volume
>> -= 2;
>> + sleep(1);
>> + mpeg_sound_set(SOUND_VOLUME, current_volume);
>> + }
>> + mpeg_pause();
>> + sleep(1); /* let mpeg thread run */
>> +
>> + /* reset volume to what it was before the fade */
>> + mpeg_sound_set(SOUND_VOLUME, global_settings.volume);
>
>
> The last sleep() in the fade out is too short, in my experience (using a
> player). The volume is reset before the MPEG thread has stopped the
> playback, so there's a brief burst of music at normal volume. I tried
> using HZ/10 as sleep, and that seems to work fine. HZ/15 is slightly too
> short.
>
Received on 2003-02-16
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy