Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: _power saving_ setting added to .cfg

Re: _power saving_ setting added to .cfg

From: Christian D <QInter_at_gmx.net>
Date: Mon, 17 Feb 2003 12:28:39 +0100 (MET)

> On Mon, 17 Feb 2003, Björn Stenberg wrote:
>
> > The power saving setting is temporary for testing only. After initial
> > testing it will be enabled permanently and the setting will go away.
> >
> > I will merge your fixes (and add wps+font to the docs) tomorrow.
>
> Note that mpeg_sound_set() needs to be called here:
>
> + else if (!strcasecmp(name, "channels")) {
> + static char* options[] = {
> + "stereo","mono","mono left","mono right"};
> + set_cfg_option(&global_settings.channel_config, value,
> + options, 4);
> + }
>
> --
> Magnus Holmgren
>

IMHO it's not necessary. The mpeg_sound_set() ist called in the
settings_apply() function. And settings_apply() is called by the cfg loader after reading
the file. This version is working fine. I've tested it.

Christian
 
Received on 2003-02-17

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew