Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: apps settings.c,1.114,1.115 settings.h,1.69,1.70 settings_menu.c,1.97,1.98 wps.c,1.178,1.179

Re: cvs: apps settings.c,1.114,1.115 settings.h,1.69,1.70 settings_menu.c,1.97,1.98 wps.c,1.178,1.179

From: Brian King <brking_at_charter.net>
Date: Mon, 24 Feb 2003 20:16:09 -0600

I used HZ/10 for a while and still noticed the problem occasionally. I
bumped it to HZ/5 and have yet to reproduce it.

-Brian


Magnus Holmgren wrote:
> Bjorn Stenberg wrote:
>
>> + /* fade out */
>> + int current_volume = global_settings.volume;
>> +
>> + while (current_volume > 20) { + current_volume
>> -= 2;
>> + sleep(1);
>> + mpeg_sound_set(SOUND_VOLUME, current_volume);
>> + }
>> + mpeg_pause();
>> + sleep(1); /* let mpeg thread run */
>> +
>> + /* reset volume to what it was before the fade */
>> + mpeg_sound_set(SOUND_VOLUME, global_settings.volume);
>
>
> The last sleep() in the fade out is too short, in my experience (using a
> player). The volume is reset before the MPEG thread has stopped the
> playback, so there's a brief burst of music at normal volume. I tried
> using HZ/10 as sleep, and that seems to work fine. HZ/15 is slightly too
> short.
>
Received on 2003-02-25

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew