Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: firmware mpeg.c,1.206,1.207

Re: cvs: firmware mpeg.c,1.206,1.207

From: Björn Stenberg <bjorn_at_haxx.se>
Date: Mon, 3 Mar 2003 15:09:01 +0100

Uwe Freese wrote:
> Found the only one point that led to imcompatibility of the CVS code with
> a 8MB AJB. Finally, CVS is 8 MB-mod compliant. :-)


> amount_to_read = MIN(mp3buflen - mp3buf_write, amount_to_read);
> +#if MEM == 8
> + amount_to_read = MIN(0x100000, amount_to_read);
> +#endif

Could you explain why the old code did not work? Your change replaces the dynamic buffer space calculation with a static 0x100000 read. Why? This should not be necessary.

-- 
Björn
Received on 2003-03-03

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy