Rockbox mail archive
Subject: Re: cvs: firmware mpeg.c,1.206,1.207Re: cvs: firmware mpeg.c,1.206,1.207
- Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 3 Mar 2003 15:11:21 +0100 (CET)
On Mon, 3 Mar 2003, Björn Stenberg wrote:
> > +#if MEM == 8
> > + amount_to_read = MIN(0x100000, amount_to_read);
> > +#endif
>
> Could you explain why the old code did not work? Your change replaces the
> dynamic buffer space calculation with a static 0x100000 read. Why? This
> should not be necessary.
As I was saying already before, the 8MB version may need different
thresholds. It should *not* require different code... AFAICT.
Date: Mon, 3 Mar 2003 15:11:21 +0100 (CET)
On Mon, 3 Mar 2003, Björn Stenberg wrote:
> > +#if MEM == 8
> > + amount_to_read = MIN(0x100000, amount_to_read);
> > +#endif
>
> Could you explain why the old code did not work? Your change replaces the
> dynamic buffer space calculation with a static 0x100000 read. Why? This
> should not be necessary.
As I was saying already before, the 8MB version may need different
thresholds. It should *not* require different code... AFAICT.
-- Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/Received on 2003-03-03
Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy