Rockbox mail archiveSubject: Re: cvs: firmware mpeg.c,1.206,1.207
Re: cvs: firmware mpeg.c,1.206,1.207
From: Daniel Stenberg <daniel_at_haxx.se>
Date: Mon, 3 Mar 2003 19:23:27 +0100 (CET)
On Mon, 3 Mar 2003, Uwe Freese wrote:
> > amount_to_read = MIN(mp3buflen - mp3buf_write, amount_to_read);
> > +#if MEM == 8
> > + amount_to_read = MIN(0x100000, amount_to_read);
> > +#endif
> As I understand it, 1,7 MB (with a 2 MB AJB) is read in one piece when
> filling the buffer the first time. With an 8 MB AJB, it is 7,7 MB. That
> means that bitswapping (or something else) is started too late (after
> reading these 7,7 MB) and data that's not bitswapped (?) is fed into the
That sounds like a bug. The mpeg thread should not feed anything to the MAS
until it is bitswapped.
Linus, you have any comment on this?
If this really is what you need, then why is this 8MB dependent (setting the
limit to 1MB)? Shouldn't this instead be made unconditionally even for 2MB
> I didn't write that mpeg.c and don't know how it exactly works! Sorry, but
> I thought it's better to have at least a working version (for 8MB) in CVS.
> (no changes when compiling as 2 MB version)
Possibly, we just don't like kludgy fixes in the code without very good
-- Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/Received on 2003-03-03