Rockbox mail archiveSubject: Re: New patch: autopreset of RTC after power-loss
From: Björn Stenberg (bjorn_at_haxx.se)
Michael Schopferer wrote:
Sounds like an excellent approach.
> config_block[0xa1] = /* seconds */
You should pack this a bit more. Day and month are both 4-bit values and could share a byte. Dayofweek is 3 bits while hour is 4 bits, so they could also share a byte.
> Now I'm working on a DaylightSavingTime-patch (DST).
I question the benefit of adding DST handling in Rockbox. If you need to toggle the bit manually, why not just change the hour field instead? Very very few devices bother with DST. Most digital clocks/watches, whose single purpose for existing is showing the time, don't even care about DST. Why then should we?
Page was last modified "Jan 10 2012" The Rockbox Crew