dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: Patch overview

Re: Patch overview

From: Magnus Holmgren <>
Date: Fri, 14 Mar 2003 20:41:19 +0100

Björn Stenberg wrote:

> #618889 "status.c updates" (learman)
> Being cosmetic only, I haven't looked much at it. 2.1 material.

Main reason for doing it is the fact that the player and the recorder
use different code to implement the same thing (battery animation) when
there's no reason for it. I'm not too fond of that... :)

(A somewhat related thing is the new .cfg writer, where a fprintf-like
function is much needed. I don't like seeing pretty much identical code
repeated a large number of times. :)

> #670744 "Add support for APE tags" (learman)
> Suffers from "compressed patch syndrome" and also gets pushed down in priority for being rather esoteric. (Foobar2000??)

Would "uncompressing" the patch make a large difference (i.e., is it
worth the effort :)? One remaining issue is that the patch doesn't
include tag skipping code for mpeg.c. The dynamic tag size makes it a
bit messy to do, but I can add that if the patch is of interest.

Btw, even if the name isn't the best, Foobar is a very good audio player
for Windows. And APE tags are also used by Monkey's Audio and MusePack

Magnus Holmgren
Received on 2003-03-14

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy