Rockbox mail archive

• Next message: Björn Stenberg: "Re: Single play mode"
• Previous message: William Pietri: "Re: Unlocking the full features of the MAS chip (short version)"
• Next in thread: Linus Nielsen Feltzing: "Re: YA S.C Q (Yet another settings.c question)"
• Reply: Linus Nielsen Feltzing: "Re: YA S.C Q (Yet another settings.c question)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

I don’t know if this is an oversight or I just don’t
understand the conventions used when adding things to
settings.c, but it looks like in some cases we check
that the bytes of config_block != 0xFF before using
the data in the byte to load the global settings, but
there are many places where this is not done... for
example, no check is done with the 9 settings starting
with “fade_on_stop” at line 670. Is this intentional?
Also “fade_on_stop” is set again later at line 695,
this time after checking that the config_block byte !=
0xFF.

Are these errors? Should I submit a patch?

Also, if the convention is to always check for 0xFF,
what if every bit of a config_block byte is used, and
the user select settings make that byte - 0xFF?

=====
Craig

rb_dev_at_yahoo.com

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com

• Next message: Björn Stenberg: "Re: Single play mode"
• Previous message: William Pietri: "Re: Unlocking the full features of the MAS chip (short version)"
• Next in thread: Linus Nielsen Feltzing: "Re: YA S.C Q (Yet another settings.c question)"
• Reply: Linus Nielsen Feltzing: "Re: YA S.C Q (Yet another settings.c question)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]