Rockbox mail archiveSubject: Re: Patch #706111 id3 tags, implemented! But an error appears!
From: Björn Stenberg (bjorn_at_haxx.se)
TP Diffenbach wrote:
The name of the field is 'tag_length', which I think fully communicates the purpose of it. I removed the sizeof() construct simply because I found it made the code unneccessarily messy.
> While not making it impossible to make errors, this I think makes it easier
I dislike macros that hide code. It is in my opinion mostly better to have slightly more complex code if it avoids having to pre-process it in your head.
I also do not like to create language constructs to protect the programmer from himself. Errors will always happen, but they are much simpler to find and fix if the code just does the job straight with as little fuss as possible.
Page was last modified "Jan 10 2012" The Rockbox Crew