From: Hardeep Sidhu <hardeeps_at_pobox.com>
Date: Tue, 17 Jun 2003 16:07:57 -0700 (PDT)

Hi Roland,

Please try the attached patch and see if it fixes your
problem.

-Hardeep

--- for_spam_at_gmx.de wrote:
> hello again,
> i have recognized that there is a minor issue with
> the simulator on win32.
> icons don`t show up correctly for me in the
> dir-browser.
> I think this is related to the underlying filesystem
> being used.
> I have ntfs (on winXP) - and so, getting the
> directory/file information with
>
> routines written for fat32 seems to give us
> different values. for me, this
> seems the
> rockbox routines aren`t "generic" enough. my
> windows explorer always shows
> a directory
> icon if it`s a directory - regardles if the fs is
> fat16,fat32,ntfs,iso9660.....or whatelse... ;)
> so should the rockbox-simulator - shouldn`t it ? but
> it is not that trivial
> to fix, i think.....
>
> regards
> roland
>
> --
> +++ GMX - Mail, Messaging & more http://www.gmx.net
> +++
> Bitte lächeln! Fotogalerie online mit GMX ohne
> eigene Homepage!
>
>


Index: rockbox//apps/tree.c
===================================================================
RCS file: /cvsroot/rockbox/apps/tree.c,v
retrieving revision 1.197
diff -u -r1.197 tree.c
--- rockbox//apps/tree.c 5 Jun 2003 09:38:25 -0000 1.197
+++ rockbox//apps/tree.c 17 Jun 2003 23:05:00 -0000
_at__at_ -292,7 +292,7 _at__at_
                 continue;
             }
 
- dptr->attr = entry->attribute;
+ dptr->attr = entry->attribute & 0x3f;
 
             /* mark mp? and m3u files as such */
             if ( !(dptr->attr & ATTR_DIRECTORY) && (len > 4) ) {
Received on 2003-06-18