From: Nix <nix_at_esperi.demon.co.uk>
Date: Wed, 16 Jul 2003 23:42:43 +0100

On Wed, 16 Jul 2003, roland yowled:
> errrr,
> strange, but in the Makefile for X11 uisimulator there IS a $DISPLAY.

I see it now. Not sure what on earth I was grepping for before...

> ifeq ($(DISPLAY),-DHAVE_LCD_BITMAP)
> MACHINEDIR = $(RECDIR)
> # not very nice to set RTC like this, but...
> RTC += -DHAVE_RTC
> else
> MACHINEDIR = $(PLAYDIR)
> endif
>
> DEFINES = -DHAVE_CONFIG_H -DGETTIMEOFDAY_TWO_ARGS -DSIMULATOR \
> $(KEYPAD) $(DISPLAY) $(EXTRA_DEFINES) $(RTC)
>
> this is the reason, why we see :0.0 in his command line - but,to tell
> the truth, i don`t have a clue, why $DISPLAY is relevant here and why
> it`s being compared to -DHAVE_LCD_BITMAP....!!??!!

It looks like the intent is to make the display type of the device
configurable at build time; but they forgot to initialise DISPLAY to the
empty string, so it inherits whatever's in the environment beforehand.

> perhaps unsetting $DISPLAY may help....?

It would; so too would this:

Index: rockbox-devel/uisimulator/win32/Makefile
===================================================================
RCS file: /cvsroot/rockbox/uisimulator/win32/Makefile,v
retrieving revision 1.61
diff -u -r1.61 Makefile
--- rockbox-devel/uisimulator/win32/Makefile 10 Jul 2003 11:52:41 -0000 1.61
+++ rockbox-devel/uisimulator/win32/Makefile 16 Jul 2003 22:41:40 -0000
_at__at_ -21,6 +21,7 _at__at_
 RECDIR = $(APPDIR)/recorder
 PLAYDIR = $(APPDIR)/player
 PLUGINDIR = $(APPDIR)/plugins
+DISPLAY =
 
 ifeq ($(DISPLAY),-DHAVE_LCD_BITMAP)
      MACHINEDIR = $(RECDIR)
Index: rockbox-devel/uisimulator/x11/Makefile
===================================================================
RCS file: /cvsroot/rockbox/uisimulator/x11/Makefile,v
retrieving revision 1.105
diff -u -r1.105 Makefile
--- rockbox-devel/uisimulator/x11/Makefile 10 Jul 2003 11:52:42 -0000 1.105
+++ rockbox-devel/uisimulator/x11/Makefile 16 Jul 2003 22:41:43 -0000
_at__at_ -20,6 +20,7 _at__at_
 APPDIR = ../../apps
 RECDIR = $(APPDIR)/recorder
 PLAYDIR = $(APPDIR)/player
+DISPLAY =
 
 ifeq ($(DISPLAY),-DHAVE_LCD_BITMAP)
         MACHINEDIR = $(RECDIR)

-- 
`We cannot get a new line down the pipe due to a blockage and we cannot
 dig up the road to clear the blockage because it is covered with the
 wrong type of tarmac.' --- British Telecom, via Mark Lowes

Received on 2003-07-17