Rockbox mail archiveSubject: Re: New Bookmark Release - 2004-01-02
Re: New Bookmark Release - 2004-01-02
From: Henrik Backe <backe_at_swipnet.se>
Date: Sun, 4 Jan 2004 23:53:41 +0100
"Magnus Holmgren" <lear_at_algonet.se> wrote in message
> Since global_bookmarkcopy is only used by parse_bookmark, one could
> consider putting it in that function (still declared static ofcourse).
> On the other hand, having it at the top makes it easier to see the total
> amount of static buffers used. :)
It was not Ben's idea to make bookmarkcopy global. I did it when I made
som space savings in parse_bookmark. I somhow thougth pointers to
was passed from the function, so I made it global to keep it in scope.
> Since a playlist filename only can be 260 chars, wouldn't it be possible
> to reduce MAX_BOOKMARK_SIZE a bit? Something like 340 seems safe...
Could be done since the filename (without path) is only there to be
browsing the bookmarks. The filename is saved last so nothing will be broken
if it is
I believe it is commit time now Daniel ;-)
Received on 2004-01-04