From: Henrik Backe <backe_at_swipnet.se>
Date: Thu, 8 Jan 2004 21:29:24 +0100

"Björn Stenberg" <bjorn_at_haxx.se> wrote in message
news:20040108193133.GC1341_at_kluster1.contactor.se...
Henrik Backe wrote:
>> If ve are gonna mix default viewers and "other" viewers in the same
>> directory we need a way to see the difference between them,
>
> In my mind there is only one class of viewer plugins: those in the viewer
dir, all treated alike.

My concern is when we have two different viewers for the same extension and
an empty viewers.config, we can't treat them
the same way then simply because we have to choose one (se my scenarios
later).

>> so we either have to stick with
>> ".rockbox/viewer/[extension]-[anything].rock" with the possibilty for
>> confusion or use somthing like ".rockbox/viewer/[extension]-default.rock"
>
> The reason I and Daniel added the [anything] part of the filename was to
avoid the problem of not knowing which plugin actually
> views which file type.
> If the dir contains hex.rock, ansi.rock and txt.rock, it's not easy seeing
which plugin you have actually assigned to view which file. > Calling them
hex-hexedit.rock ansi-johnsviewer.rock and txt-emacs.rock at least gives the
possibility of keeping an identifying
> mark on each file.

I understand that, and we can have it that way but then we might run into a
problem with "-" when we have two different
viewers for the same extension and an empty viewers.config (se my scenarios
later).

>> Another drawback, if we keep all the viewers in the same directory, with
the
>> ".rockbox/viewer/[extension]-[anything].rock" scheme is that then we can
not
>> use "-" in viewer plugin names.

> Sure we can: txt-text-viewer.rock would be perfectly acceptable. We simply
can not use "-" in extensions.

Scenario I:

- missing or empty viewers.config
- one viewer named txt-text-viewer.rock
- one viewer named txt-henry-hills-screwed-up-txt-viewer.rock (my alternate
txt viewer)

Problem: which one to choose.

Scenario II:
- missing or empty viewers.config
- one viewer named txt-text-viewer.rock
- one viewer named henry-hills-screwed-up-txt-viewer.rock (my alternate txt
viewer)

Problem: we get henry-hills-screwed-up-txt-viewer.rock bound to the
extension henry (or viewer)
and waste one entry in the viewer table in RAM

Scenario III:
- missing or empty viewers.config
- one viewer named txt-text-viewer.rock
- one viewer named henry_hills_screwed_up_txt_viewer.rock (my alternate txt
viewer)

No problems (except for the poor sod who binds .txt to
henry_hills_screwed_up_txt_viewer.rock
in viewers.config)


.../Henrik
Received on 2004-01-08