Rockbox mail archiveSubject: Re: (Another) New Bookmark Release - 2004-01-10
Re: (Another) New Bookmark Release - 2004-01-10
From: Henrik Backe <backe_at_swipnet.se>
Date: Wed, 14 Jan 2004 09:45:19 +0100
"Björn Stenberg" <bjorn_at_haxx.se> wrote in message
> Excellent! I have now, finally, committed this code to CVS.
> I made a number of changes to the code though:
> - Removed the bookmark_autobookmark() call from the Disk Info screen(!) in
> debug_menu. I assume that was just forgotten debug code.
No debug code, I put it there because there is an mpeg_stop()
there. The question is, should implicit stop of playback cause
a bookmark. There is another implicit mpeg_stop() in rolo.c
I would also like to have autobookmarking when the sleeptimer kicks
in, but then we have to increase the power thread stack size and
add a call from firmware code to apps code (which is not kosher).
> I still have a few small issues with the bookmark feature:
> - I think the icon is nice, but it doesn't look like a bookmark at all.
> an excellent "document" icon, though! :-)
This one is also mine, I was aiming for the pre-mp3 "dog-ear" type of
bookmarking. The resemblance to "this face up" icons on copier machines
are purely coincidental :-)
Received on 2004-01-14