Rockbox mail archiveSubject: Re: Various bug fixes and improvements - where to put?
Re: Various bug fixes and improvements - where to put?
From: Linus Nielsen Feltzing <linus_at_haxx.se>
Date: Tue, 02 Mar 2004 10:05:58 +0100
Jens Arnold wrote:
> I worked around the problem by replacing set_irq_level by
> inline assembler (only in lcd_write_data).
I hope you restore the current level and not just set it to 0 to enable
the interrupts again.
The lcd_update() function is called at boot time with the interrupts
disabled, and the sti() call in lcd_write_data() enabled the interrupts
prematurely. This is why I finally decided to remove the cli/sti functions.
Or we could just remove the interrupt disabling in lcd_write_data(). It
isn't needed, because no interrupt changes port B anyway.
Received on 2004-03-02