Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Various bug fixes and improvements - where to put?

Re: Various bug fixes and improvements - where to put?

From: Jens Arnold <arnold-j_at_t-online.de>
Date: Tue, 02 Mar 2004 18:38:25 +0100

Hello Linus

>> I worked around the problem by replacing set_irq_level by
>> inline assembler (only in lcd_write_data).

> I hope you restore the current level and not just set it to 0
> to enable the interrupts again.

Yes, I did store the current irq level in the beginning and
reset it to the same level at the end (I just saved me the
hassle to shift it 4 bits to the right and then back to the
left).
But since both you and Jörg vote for taking it out completely I
will do so before preparing my patches.

Regards, Jens

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on 2004-03-02

Page was last modified "Sat May 23 08:12:40 2020" The Rockbox Crew