From: Björn Stenberg <bjorn_at_haxx.se>
Date: Mon, 22 Mar 2004 01:13:02 +0100

SourceForge.net wrote:
> Submitted By: Tat Tang (tat_tang)
>
> This is the unified Traditional/Simplified Chinese patch. It
> will also build the normal v2.2 Rockbox.

Could you explain a bit about this patch for us with limited experience with unicode and the various chinese character sets?

- Is support for both big5, gb and unicode necessary? Those lookup tables use 15-30 KB code space. Are all three code tables regularly used for file names and ID3 tags?

- If we need all three, can these tables be moved outside the main code somehow? Maybe loaded at boot? Adding large chunks of code for each multibyte character set we want to support is not sustainable. Making separate builds is no fun either. We already have three different recorder builds, adding two different chinese language builds gives a total of nine recorder builds!

- It is not sufficient to raise the limit in scramble.c to allow making 400KB large .ajz files. Those files cannot be loaded by the Archos firmware. Did you test the code with Rockbox burned in flash?

-- 
Björn
_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

Received on 2004-03-22