Rockbox mail archiveSubject: Re: Battery percentage, info screen, and bookmarks
Re: Battery percentage, info screen, and bookmarks
From: Benjamin <mailinglists_at_samuraipanda.com>
Date: Tue, 13 Apr 2004 07:23:23 -0800
I think that creating the bookmark after the user stopped playback will be a
bit of an interesting problem because the bookmark code gathers information on
what is currently playing from calls provided outside of bookmarking and the
assumptions that bookmarking takes.
To create a bookmark, the code uses these functions:
1. mpeg_current_track() in create_bookmark(). This is to get the offset and
elapsed time information.
2. playlist_get_seed() in create_bookmark(). This gets the seed used to
randomized the playlist.
3. playlist_get_name() in create_bookmark(). This gets the playlist name.
4. playlist_get_resume_info() in create_bookmark(). This gets the resume index.
5. playlist_get_name() in write_bookmark(). This is used to create the
bookmark file name.
All of these are needed to generate a "bookmark" correctly, so if these
change between when the mp3 was stopped and when the bookmark is created, the
bookmark won't be what is expected.
Let me mull it over for the next couple of days to see if I can figure a way
to do it.
---------- Original Message -----------
From: Cristian <cguiducci_at_gostec.net>
To: Rockbox development <rockbox_at_cool.haxx.se>
Sent: Tue, 13 Apr 2004 10:04:24 +0200
Subject: Battery percentage, info screen, and bookmarks
> Aman wrote:
> > Just wanted to report, if I may, that the battery percentage on the
> >info screen is not being voiced on this V2, though this well may be user
> My ajb recorder 20, behaves the same, and as a small suggestion, it would
> be better if the battery status could be spoken first, since all
> other information like the disc space is not required so often.
> For Benjamin...
> I read your comments yesterday on the nice bookmark features, but,
> would it be possible to bookmark after pressing stop, this would
> allow us to make it assisted by talkbox, and as Joerg and I thought,
> an index must still be present in the system after stopping, given
> that the "resume" feature uses it even after switching off the unit.
> I personally don't use the bookmark on stop feature, because I would
> end up with tens of unwanted bookmarks. Thanks to everybody.
------- End of Original Message -------
Received on 2004-04-13