Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Small bookmarking bug

Re: Small bookmarking bug

From: Henrik Backe <backe_at_swipnet.se>
Date: Tue, 4 May 2004 16:08:17 +0200

"c0utta fish" <c0utta_at_hotmail.com> wrote in message
news:BAY10-F12xMs1HReect00006eec_at_hotmail.com...
> Henrik,
>
> That's not the problem I see (although the patch might fix it) - I only
have
> MRB turned on. There are no bookmark files in the folder in question. I
> have checked the MRB file in .rockbox and it points to the deleted file,
but
> still loads the next file in the folder.
>
> Shouldn't the parse_bookmark function check if the file actually exists
> before returning that the parse is a success ?
>

The MRB is a bookmark file so anything that works for "ordinary"
bookmarks should work for the MRB. I've taken a closer look at the
patch and it will show a splash instead of playing the "next" file.
But it would be better check for the existence of the file in
parse_bookmark.
and not show it as a valid bookmark in select bookmark.
I'll add the check to parse_bookmark soonish.

.../Henrik



_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on 2004-05-04

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy