From: Jens Arnold <arnold-j_at_t-online.de>
Date: Fri, 03 Sep 2004 20:43:49 +0200

Hello Daniel

>> (1) A stray "_at_echo: not found" is displayed

> Can you figure where/when/why?

Figured it out meanwhile:
In lines 145 and 148 (building rockbox.ucl), you replaced "echo"
by "_at_echo". However, this part is not makefile syntax, but shell
syntax, and the shell doesn't know "_at_echo".

>> (2) There are _loads_ of TAB chars in the makefile

> Makefiles are supposed to have heaps of tab characters, and so
> they did even before my patch.

Ah ok. I just wondered because
(1) http://rockbox.haxx.se/docs/contributing.html says:
"Always indent your code with four spaces. Don't use TAB
characters, as that will mess up code display in CVS, printing,
and a zillion other places." and
(2) In some places the indentation indeed does not use TABs, but
multiple spaces.


> Thanks for the feedback.

Np.

Regards, Jens

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on 2004-09-03