From: Ray Lambert <listlizard_at_interthingy.net>
Date: Mon, 17 Jan 2005 12:10:55 -0500

>Date: Mon, 17 Jan 2005 08:53:14 +0100
>From: Linus Nielsen Feltzing <linus_at_haxx.se>
>
>Ray Lambert wrote:
>
>
>>> Since my post, I've found a new way to do from mpeg.c which was
>>> pretty easy and seems to be more accurate. I put the check in
>>> playback_tick() (since that's where id3->elapsed gets updated). This
>>> seems to work very well but I'm not sure if it's a good design
>>> decision to put my code there.
>>
>>
>That's where I would put it. [...]
>
>
>I think it sounds perfectly OK.
>
>Bring on the patch! :-)
>

Cool.

Okay, I have just one more question for you.

I've implemented most of the functionality in a new module called
abrepeat.c/h. I initially placed this module in 'apps'. However, I am
now calling it from mpeg.c, which, of course, cannot access abrepeat.h
over in apps (and also therefore can't see the #define that disables it
all). I've been calling it by put putting extern's in mpeg.c. (There
are other things that do that as well, such as playlist.c.) But this is
somewhat ugly.

I'm wondering if I should move abrepeat.c/h into the firmware directory
and export the header. I'm not sure if this module meets the criteria
for 'firmware' though (which seems to be low-level & kernel stuff).
What do you prefer?

Thanks again for all your help!

~ray

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on 2005-01-17