Rockbox mail archiveSubject: Re: AJR v1 battery recharging patch
Re: AJR v1 battery recharging patch
From: Jens Arnold <arnold-j_at_t-online.de>
Date: Fri, 04 Mar 2005 08:16:07 +0100
>>> I fixed the (absence of) battery filtering in the latested
>>> patch (050302.patch). Please try the Ondio again, it should
>>> work now.
>> It does, patch committed, thank you.
>> One tiny nitpick: The recorder now sucessfully got rid of the
>> question mark minute, in the battery indicator. For the
>> Ondio, I still see this. (Especially useless since the Ondio
>> is not recovering from a HD spinup)
> EXCELLENT! I'll get a fresh copy from CVS and start the
> improvement cycle again. I'll look into the "?" as well as the
> other improvements we discussed on the email list.
Found two more things:
1) The charging state display doesn't work properly (charging/
top off/ trcikle charge), in all of 'Rockbox Info', the debug
menu, and the battery charging animation. It always displays
'charging' even if the algorithm is obviously in trickle mode
already as long as the charger is connected. I'd like to know
when my batteries are full...
2) A hint regarding the one minute '?' display on Ondio. This
seems to be related to the multiple battery type handling. It
only happens when the battery type is set to 'NiMH', not when
it is set to 'Alkaline'. Alkaline is the default type (0), so
I suspect this is a question of init sequence. The powermgmt
threads obviously starts before the main init sets the
To solve this, set_battery_type() would neet to do a proper
re-init of the battery level filtering, instead of simply
resetting it to -1 in order to cause it to re-init. I
implemented it that simple way back then because the delay
used to be there anyway.
Received on 2005-03-04