Rockbox mail archiveSubject: Re: Warnings in musepack
Re: Warnings in musepack
From: Thom Johansen <thomj_at_pvv.ntnu.no>
Date: Tue, 14 Jun 2005 18:38:54 +0200
> Hi All,
> I was doing a cleaning round in rockbox (to get iriver builds warning
> free), and there are 18 warnings left, all in mpc_decoder.c because
> mpc_decoder_bitstream_read(...) is of the mpc_int32_t type, wich is
> defined as: "typedef unsigned int mpc_uint32_t;" And it's compared to a
> lot of ints.
> I'm not sure how to fix this (it's unsigned for a reason I guess?), but
> changing it to signed might give overflow troubles. On the other side,
> the problems with these overflowing values will cause trouble with the
> signed/unsigned comparison we do now too.
> So: Does anybody know why it's unsigned? And can I change it to signed?
> or should I cast all uses of that function wich cause a warning to int?
Seeing as how this really isn't our code, you might want to confer
with the Musepack people on this. They've got a forum and an IRC
channel. A change like this really should be put in their code as
Received on 2005-06-14