Rockbox mail archiveSubject: Re: The A-B patch (was: Any objections against a feature-freeze for the 2.5 release?)
Re: The A-B patch (was: Any objections against a feature-freeze for the 2.5 release?)
From: Linus Nielsen Feltzing <linus_at_haxx.se>
Date: Wed, 06 Jul 2005 22:28:49 +0200
Ray Lambert wrote:
> Does anyone control what goes in then? Or do you just back things
> out when someone submits something that isn't popular?
If someone does that, we seek him up and kill him. :-)
> For my own part (regarding my A-B Repeat patch) I've tried to be
> careful to cross all the t's and dot all the i's but I discovered
> after posting my latest update that I accidentally broke the
> simulator. I usually check that before releasing but forgot to this
> time. I will post a new update soon that fixes this.
While you do that, also make sure that your LANG entries are last in the
file. Also make sure that you bump the setting block version number,
since the repeat setting must be 3 bits instead of 2 (thanks to the new
"shuffle" repeat mode.
> As for solving the problem on all of the devices, this can be very
> hard to do sometimes (even with the simulator) for devices that you
> don't have access to for testing. And the problem is only getting
> worse as new devices are added.
Absolutely. We can't blame anyone for messing up a device he doesn't
own. However, one should always have in mind that there are more platforms.
> As for the display, I've implemented a graphical marker to show the A
> & B marks for 'HAVE_LCD_BITMAP' devices.
I'm not sure how they should look like, but they look like they are one
pixel too high in my (default) WPS. I had to change the drawing code due
to the LCD API change, maybe I screwed up somehow...
> If all else fails, I've wrapped all of my code in '#ifdef
> AB_REPEAT_ENABLE' (defined in abrepeat.h) so the feature can just be
> disabled on devices that aren't yet supported (or which cannot be
No, you used #if AB_REPEAT_ENABLE. I'd prefer #ifdef, and (temporarily)
have it in the config-xxx.h files.
Received on 2005-07-06