Rockbox mail archiveSubject: Re: The A-B patch (was: Any objections against a feature-freeze for the 2.5 release?)
Re: The A-B patch (was: Any objections against a feature-freeze for the 2.5 release?)
From: Ray Lambert <listlizard_at_interthingy.net>
Date: Fri, 08 Jul 2005 01:49:33 +0000
> On Thu, 7 Jul 2005 11:40:01 -0400 (EDT), Ray Lambert
> <listlizard_at_interthingy.net> wrote:
>> The markers are usually drawn as an arrow head with the A marker
>> right and B pointing left (if the markers are too close together, only a
>> vertical bar is drawn). They are drawn on top of the progress bar in
>> mode so they still make some sense regardless of the song/scroll bar
>> position. There are no hard-coded positions and only the height is
>> hard-coded. The routine that does the actual drawing is in abrepeat.c
>> (where all functional ABR code is). It is called from wps-display.c on
>> the line following the scrollbar() call. The hard-coded height value
>> appears in this call and is the same as used in the scrollbar()
>> call. All
>> other values are the ones calculated locally as the screen is being
>> laid-out and drawn.
> Isnt the scrollbar taller in iriver than recorder?
It may be. The latest code I've seen was from 6/14. If it's changed
since then, I haven't seen it. In the 6/14 code, I don't see any code
for iriver and there's only one call to scrollbar() and it hard-codes
the height as 6 pixels.
Received on 2005-07-08