Rockbox mail archiveSubject: Re: two patches: proper WAV file handling + APEv2&id3v1 tags for everyone
Re: two patches: proper WAV file handling + APEv2&id3v1 tags for everyone
From: nobby nobbs <nobbynobbs_at_gmail.com>
Date: Tue, 26 Jul 2005 16:07:41 +0100
PLEAAAAAAAAAAAAAAASE commit the apev2 for mp3 patch! foobar hates my id3
tags for some reason and cant read 50% of them...
On Tue, 26 Jul 2005 15:20:49 +0100, Frederic Devernay
> I just uploaded two patches on sourceforge (plus the two patches
> together, since they touch close regions of metadata.c).
> I know the rockbox development team is not in favor of APEv2 tags, but
> since the code is there for wavpack, why not use it for other file
> Besides, APEv2 tags handling will make foobar2000 and mp3gain users VERY
> 1245274 APEv2 and id3v1 tags for any file format :
> APEv2 and id3v1 tags can be used to tag any file
> format. When a file has both tags, id3v1 is at the end
> and APEv2 just before it.
> This patch fixes this and adds tags handling for any
> file format (even wavpack, which had only APEv2 tags).
> For mpa (mp1,mp2,mp3), if the user choses to use id3v1
> tags in favor of id3v2, APEv2 tags won't be parsed either.
> 1245261 proper WAV file handling :
> This patch adds:
> - correct parsing of WAV header, even if it's not the
> canonic 44-byte header
> - handling of WAV files other than 44.1/16bits/stereo
-- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ _______________________________________________ http://cool.haxx.se/mailman/listinfo/rockboxReceived on 2005-07-26