|
Rockbox mail archiveSubject: Re: two patches: proper WAV file handling + APEv2&id3v1 tags for everyoneRe: two patches: proper WAV file handling + APEv2&id3v1 tags for everyone
From: Ronald Teune <rtwolf_at_gmx.net>
Date: Tue, 26 Jul 2005 22:38:49 +0200 Hi, did you test the WAV handling for 8 bit files? http://www.borg.com/~jglatt/tech/wave.htm (I came across this while looking for how to write my own wave files) This page has an interesting story of wave-files and how they came into existence. Quote: "Furthermore, there are lots of inconsistencies, for example how 8-bit data is unsigned, but 16-bit data is signed." If you do have covered this (I read through your patch, but could not find it - could be my coding skills), or if the dsp chip has covered this, then.. ah well, the wave file story is still interesting. :-) Ronald On Tue, 26 Jul 2005 16:20:49 +0200, Frederic Devernay <frederic.devernay_at_m4x.org> wrote: > Hi, > > I just uploaded two patches on sourceforge (plus the two patches > together, since they touch close regions of metadata.c). > I know the rockbox development team is not in favor of APEv2 tags, but > since the code is there for wavpack, why not use it for other file > formats? > Besides, APEv2 tags handling will make foobar2000 and mp3gain users VERY > happy. > > Fred > > 1245274 APEv2 and id3v1 tags for any file format : > APEv2 and id3v1 tags can be used to tag any file > format. When a file has both tags, id3v1 is at the end > and APEv2 just before it. > This patch fixes this and adds tags handling for any > file format (even wavpack, which had only APEv2 tags). > For mpa (mp1,mp2,mp3), if the user choses to use id3v1 > tags in favor of id3v2, APEv2 tags won't be parsed either. > > 1245261 proper WAV file handling : > This patch adds: > - correct parsing of WAV header, even if it's not the > canonic 44-byte header > - handling of WAV files other than 44.1/16bits/stereo > _______________________________________________ > http://cool.haxx.se/mailman/listinfo/rockbox > -- http://www.georgedillon.com/web/html_email_is_evil.shtml _ ASCII ribbon campaign ( ) - against HTML email X & .doc attachments / \ _______________________________________________ http://cool.haxx.se/mailman/listinfo/rockboxReceived on 2005-07-26 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |