|
Rockbox mail archiveSubject: Patch for arbitrary vorbis comments in wpsPatch for arbitrary vorbis comments in wps
From: Mark Arigo <m_arigo_at_yahoo.com>
Date: Fri, 5 Aug 2005 11:42:42 -0700 (PDT) I've submitted a patch to the tracker that allows for the display of arbitrary vorbis comments (besides the supported artist, album, year, etc) in the wps. Vorbis comments take the form TAGNAME=VALUE, so a new wps variable is used: %ix"TAGNAME" quotes included. TAGNAME should match exactly. For example, I sometimes use a PERFORMER tag if there are guest artists on a particular track by an artist. This wps line will display the PERFORMER tag, otherwise defaults to the artist. ?%ix"PERFORMER"<%ix"PERFORMER"|%ia> This only works for non-supported tags...%ix"ARTIST" will not display anything. The following files were changed: apps/metadata.c apps/wps-display.c firmware/replaygain.c firmware/exports/id3.h Currently, only 8 arbitrary vorbis comments are stored (beyond the supported ones) if they all fit in the buffer. Since I store the vorbis comments in the mp3entry.id3v2buf[], I increased its size from 300 to 500 (for iriver), this may be overkill, and can be reduced. This patch works for both OGG and FLAC files with vorbis comments. I'm sure somebody could modify the apetag metadata handling to do something similar. The patch (#1252758) is here: https://sourceforge.net/tracker/index.php?func=detail&aid=1252758&group_id=44306&atid=439120 Mark __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ http://cool.haxx.se/mailman/listinfo/rockbox Received on 2005-08-05 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |